Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with exchange abstraction #59

Closed
calumrussell opened this issue Mar 13, 2024 · 0 comments
Closed

Problem with exchange abstraction #59

calumrussell opened this issue Mar 13, 2024 · 0 comments

Comments

@calumrussell
Copy link
Owner

calumrussell commented Mar 13, 2024

https://github.com/calumrussell/alator/blob/b2ff508da56daea3f8583ee3d44aa946e4785c28/crates/rotala/src/orderbook/fortuna.rs#L98

This implies that there is going to be something wrong with the exchange impl if we try to implement - #54 - a lot of the types were being passed through in uist but this becomes more tricky with fortuna as the order types are significantly more complex. Any client will bind to those types meaning that they need to be passed explicitly.

  • Move Diana into Uist
  • Move Fortuna into Jura
  • Make sure PenelopeQuote doesn't leak.

Tests also overlap, we can just present single interface to test against

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant