Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example string values for properties defined with date-time format #238

Open
gmuratk opened this issue Jan 10, 2025 · 2 comments
Open
Labels

Comments

@gmuratk
Copy link
Contributor

gmuratk commented Jan 10, 2025

Problem description

It has been reported that some tool chains are having issues with string values without quotes for properties defined in date-time format.
In device-reachability-status-subscriptions.yaml and device-roaming-status-subscriptions.yaml properties startsAt, expiresAt, and subscriptionExpireTime cause such issue.

Expected behavior

Wrap all the examples of such properties in quotes in all of the API definitions.
Example:

    startsAt: 2024-07-03T21:12:02.871Z --> "2024-07-03T21:12:02.871Z"
    expiresAt: 2024-07-03T21:12:02.871Z --> "2024-07-03T21:12:02.871Z"

Alternative solution

Additional context

@sachinvodafone
Copy link
Collaborator

Hi @gmuratk, Nice catch !!! I am unable to recall but we have agreed to have single quote for String value like

startsAt: '2024-07-03T21:12:02.871Z'
expiresAt: '2024-07-03T21:12:02.871Z'

same has been used across all other APIs too

@eric-murray
Copy link
Collaborator

@sachinvodafone
It can be single or double quotes. Doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants