Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 5XX errors? #26

Open
eric-murray opened this issue Feb 4, 2025 · 4 comments · May be fixed by #28
Open

Remove 5XX errors? #26

eric-murray opened this issue Feb 4, 2025 · 4 comments · May be fixed by #28

Comments

@eric-murray
Copy link
Contributor

Problem description
Commonalities r2.2 states that 5XX errors should not be documented unless they are relevant to the use case. That is not the case for this API so they should be removed.

Expected behaviour
Remove 5XX errors from kyc-tenure.yaml

Alternative solution
Leave them in if someone can show they are relevant to the use case

Additional context
Application developers will understand that 5XX errors may be returned by a server under certain conditions, even if they are not documented in the YAML
@eric-murray eric-murray changed the title Remove 5XX errors Remove 5XX errors? Feb 4, 2025
@GillesInnov35
Copy link
Contributor

hello @eric-murray, from what I understand we've to create a PR to apply new commonalities r2.2 as it has been done for others kyc. Tell me if you'd like I take the point.

Gilles

@eric-murray
Copy link
Contributor Author

Hi @GillesInnov35

For this issue (5XX errors), it is up to the sub-project if the errors are kept in the OAS definition or not. So we have a decision to make.

If the decision is to remove them, then a PR is required. It should be possible to raise, approve and merge such a PR on the same day.

@GillesInnov35
Copy link
Contributor

thanks @eric-murray,

Fernando, Toshi, WDYT about updating errors section as it has been done for others kyc API ?

BR
Gilles

@ToshiWakayama-KDDI
Copy link

Hi @GillesInnov35 , cc @eric-murray ,

I understand the KYC Match/Fill-in/Age-verification APIs proposals includes removal of 501, 502, 504 and 429, which could apply to Tenure API. I am not much involved in Tenure API discussions, though.

BR
Toshi

@GillesInnov35 GillesInnov35 linked a pull request Feb 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove non mandatory errors following new commonalities camaraproject/Tenure
3 participants
@ToshiWakayama-KDDI @eric-murray @GillesInnov35