Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processes are not closing. #49

Open
tiagofaustino opened this issue Nov 12, 2018 · 6 comments
Open

Processes are not closing. #49

tiagofaustino opened this issue Nov 12, 2018 · 6 comments
Assignees
Labels
BUG Something isn't working

Comments

@tiagofaustino
Copy link

tiagofaustino commented Nov 12, 2018

This plugin are generating repeated processes and do not close. Even after closing Eclipse 2018-09 (Build id: 20180917-1800). As an example I have a "camel-lsp-server-1.0.0-SNAPSHOT.jar" jar of the "camel-tooling" plugin.

image

@apupier apupier added the BUG Something isn't working label Nov 12, 2018
@apupier apupier self-assigned this Nov 13, 2018
@apupier
Copy link
Member

apupier commented Nov 13, 2018

@tiagofaustino thanks for the report.

it is "normal" that a new process is launched for each opened editor.
I cannot reproduce to have them still running when closing Eclipse. In fact, a process is launched when an editor opens and when the editor is closing it is shutdown.
Newer version is available on the update site. I'm wondering if I'm not reproducing because of improvements done recently while fixing camel-tooling/camel-language-server#165
Can you try to update please?
If you still reproduce, can you precise which editor you are opening: XML Editor, Java Editor, Generic Text editor, Camel route Editor?

@apupier
Copy link
Member

apupier commented Nov 28, 2018

@tiagofaustino I'm closing this issue as I'm unable to reproduce. If you have time to provide more information, please reopen it.

@apupier apupier closed this as completed Nov 28, 2018
@KingRabbid
Copy link

KingRabbid commented Jul 3, 2020

Hi,

I have similar issue, i.e. the LSP instance is not closed, remains open and this adds to a large memory consumption (see the picture: Camel-lsp-instances).

I'm using STS 4.7.0 and the Apache Camel LSP "Tooling for Apache Camel based on Apache Camel implementation of Language Server Protocol 1.0.0.202007031354 com.github.cameltooling.lsp.eclipse.client.feature.feature.group null"

I've opened a couple of "Generic Editor - Spring properties" tabs, closed them, inspected a couple of definitions, etc. Now I have 4 of them opened, another 5 XML tabs (Maven POM editor) and 2 Java editor tabs.

Just an additional info: after closing the IDE the java process was still alive for at least 1 minute. However for the list in the picture all java process were alive for long time.

Thanks

@apupier apupier reopened this Jul 4, 2020
@apupier
Copy link
Member

apupier commented Jul 10, 2020

I'm still unable to reproduce. The server process is terminated when the editor is closed fo rme.

Can you take a java thread dump on the process that remains please? (different ways to do so explained here https://www.baeldung.com/java-thread-dump )

@KingRabbid
Copy link

Hi,

I'm attaching the requested input: camel-lsp-td-1.txt. Could this be relevant that I'm having my laptop in Sleep mode from time to time?

Now I have only XML files opened in editor (for some time already) but as you can see in the process list there are 7 alive.
camel-lsp-proc

Also few prints for memory & thread usage during a Flight recording.
camel-lsp-memory
camel-lsp-threads

Thanks

@apupier
Copy link
Member

apupier commented Apr 9, 2021

I gave another look but still cannot reproduce and not found anything that is giving ideas where to look at :-(

Could this be relevant that I'm having my laptop in Sleep mode from time to time?

I do not see how but why not. i tried to put in sleep but cannot reproduce neither.

I'm attaching the requested input: camel-lsp-td-1.txt.

thanks. Unfortunately, evrythign seems normal.

I noticed that you were on Spring Tool Suite 4 so gave a try with it and cannot reproduce neither

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants