Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): bump chart to v12 #26

Merged
merged 4 commits into from
Jan 30, 2023
Merged

feat(helm): bump chart to v12 #26

merged 4 commits into from
Jan 30, 2023

Conversation

jbarascut
Copy link
Member

No description provided.

@jbarascut jbarascut requested a review from a team as a code owner January 27, 2023 13:33
@lentidas
Copy link
Contributor

lentidas commented Jan 30, 2023 •
edited
Loading

Just to document this here: https://github.com/bitnami/charts/tree/main/bitnami/thanos#to-1200
Although the chart is upgraded to v12 there are no breaking changes. The guys at Bitnami decided to bump the major only because they upgraded the MinIO subchart a major version also, which does not affect us since we do not use that subchart.

I think you only need to update the version on the README.md to reflect the upgrade. I did it, so we can merge this whenever you want.

lentidas
lentidas previously approved these changes Jan 30, 2023
View reviewed changes
fsismondi
fsismondi previously approved these changes Jan 30, 2023
View reviewed changes
@jbarascut
chore: release 1.0.0-alpha.8
0704bf9 
Release-As: 1.0.0-alpha.8
@jbarascut jbarascut merged commit ad51036 into main Jan 30, 2023
@jbarascut jbarascut deleted the bump_version branch January 30, 2023 16:04
@github-actions github-actions bot mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsismondi fsismondi fsismondi approved these changes

@lentidas lentidas lentidas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbarascut @lentidas @fsismondi