Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure)!: use managed identity to access object storage #33

Merged
merged 5 commits into from
Apr 6, 2023

Conversation

modridi
Copy link
Contributor

@modridi modridi commented Mar 27, 2023

Description of the changes

User can now choose between key-based and identity-based access to object storage.
The variable metrics_storage is refactored as follow:

metrics_storage = {
  container       = azurerm_storage_container.metrics.name
  storage_account = azurerm_storage_account.metrics.name

  managed_identity_node_rg_name = module.cluster.node_resource_group # Unset when using account key.

  storage_account_key = azurerm_storage_account.metrics.primary_access_key # Unset when using a managed identity
}

Imporant: when using identity-based access, aad-pod-identity must be declared as module dependency.

Breaking change

  • No
  • Yes (in the Helm chart(s))
  • Yes (in the module itself): see new variable for setting storage parameters above.

Tests executed on which distribution(s)

  • KinD
  • AKS (Azure)
  • EKS (AWS)
  • Scaleway
  • SKS (Exoscale)

@modridi modridi marked this pull request as ready for review March 27, 2023 12:33
fsismondi
fsismondi previously approved these changes Mar 28, 2023
lentidas
lentidas previously approved these changes Apr 4, 2023
aks/extra-variables.tf Outdated Show resolved Hide resolved
Co-authored-by: Gonçalo Heleno <33546359+lentidas@users.noreply.github.com>
@modridi modridi merged commit 6efba02 into main Apr 6, 2023
@modridi modridi deleted the ISDEVOPS-203 branch April 6, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants