Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form input autocomplete #1356

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

vsgoulart
Copy link
Contributor

@vsgoulart vsgoulart commented Feb 11, 2025

This PR fixes the autocompletion on the form input, before we were just completing the variable names which resulted in invalid JSON.

Closes camunda/camunda-modeler#4758

  • This PR adds a new form-js element or visually changes an existing component.

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 11, 2025
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 11, 2025 11:15 Destroyed
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 11, 2025 11:39 Destroyed
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 11:17 Destroyed
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 12:04 Destroyed
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 12:15 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from 28d2731 to bbe3595 Compare February 12, 2025 14:37
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 14:37 Destroyed
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 14:54 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from ef6dd0d to 3bebd43 Compare February 12, 2025 15:02
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 15:02 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from 3bebd43 to 5242bcb Compare February 12, 2025 15:40
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 15:40 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from 5242bcb to ca15462 Compare February 12, 2025 15:48
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 15:48 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from ca15462 to f539f20 Compare February 12, 2025 15:52
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 15:52 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from f539f20 to 7f5ce7b Compare February 12, 2025 16:03
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 16:04 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from 7f5ce7b to 1c165ce Compare February 12, 2025 16:34
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 16:35 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from 1c165ce to 77edd95 Compare February 12, 2025 16:39
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 16:40 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from 77edd95 to 4f1a0de Compare February 12, 2025 16:46
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 16:46 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from 4f1a0de to 5f7d162 Compare February 12, 2025 17:06
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 17:06 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from 5f7d162 to 805b85c Compare February 12, 2025 17:19
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 17:20 Destroyed
@vsgoulart vsgoulart force-pushed the fix-form-input-autocomplete-2 branch from 805b85c to 3394fc3 Compare February 12, 2025 17:30
@github-actions github-actions bot temporarily deployed to demo-fix-form-input-autocomple February 12, 2025 17:30 Destroyed
@vsgoulart vsgoulart marked this pull request as ready for review February 12, 2025 17:53
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 12, 2025
@vsgoulart vsgoulart requested a review from Skaiir February 12, 2025 17:53
@vsgoulart vsgoulart changed the base branch from develop to main February 12, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field suggestions in form playground input lead to validation error
1 participant