fix: identity base url not configured #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanlukas
requested review from
jessesimpson36 and
a team
and removed request for
jessesimpson36
aabouzaid
reviewed
Jun 24, 2024
There was a problem hiding this comment.
@jonathanlukas Thanks for the PR 🙌
I need to get this checked by the Identity team (I've sent them already).
Also, should we do that for previous charts too?
|
@aabouzaid I stumbled across this when using an external idp. I think this feature was present in version 9? |
|
@jonathanlukas for this kind of app knowledge we will need some input from @camunda/identity team. |
dlavrenuek
approved these changes
Jun 27, 2024
|
Thanks @dlavrenuek for confirmation and @jonathanlukas for the PR 🙌 |
aabouzaid
pushed a commit
that referenced
this pull request
Jun 27, 2024
aabouzaid
pushed a commit
that referenced
this pull request
Jun 28, 2024
This was referenced Jul 2, 2024
Closed
aabouzaid
pushed a commit
that referenced
this pull request
Jul 13, 2024
This was referenced Jul 13, 2024
Closed
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
closes #2027
What's in this PR?
This PR add the identity baseUrl to all components that are missing it.
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: