Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: define Web Modeler Admin role in identity #2395

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix: define Web Modeler Admin role in identity #2395

merged 2 commits into from
Oct 1, 2024

Conversation

aabouzaid
Copy link
Member

@aabouzaid aabouzaid commented Oct 1, 2024 •
edited
Loading

Which problem does the PR fix?

Fixes: #2339

What's in this PR?

Because the Web Modeler Admin role was missing so Identity wasn't able to assign any role to the Identity's first user.

The role was assigned to the user in PR no. #2326, but the role wasn't added.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@aabouzaid aabouzaid self-assigned this Oct 1, 2024
@aabouzaid aabouzaid force-pushed the 2339-identity-first-user-permissions branch from bc41eea to a876354 Compare October 1, 2024 13:41
@aabouzaid aabouzaid added the test-persistent Don't delete the Helm deployment created by the PR and use fixed names label Oct 1, 2024
@aabouzaid aabouzaid force-pushed the 2339-identity-first-user-permissions branch from b2df8ff to 8de561e Compare October 1, 2024 14:30
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha October 1, 2024 14:36 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha-upgrade October 1, 2024 14:36 Destroyed
@aabouzaid aabouzaid force-pushed the 2339-identity-first-user-permissions branch from 9c71abc to 879da92 Compare October 1, 2024 14:52
@aabouzaid aabouzaid force-pushed the 2339-identity-first-user-permissions branch from 2545348 to 109b0b3 Compare October 1, 2024 14:55
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha-upgrade October 1, 2024 14:58 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha October 1, 2024 14:58 Destroyed
@aabouzaid aabouzaid force-pushed the 2339-identity-first-user-permissions branch from 29ec0bf to 04914a6 Compare October 1, 2024 15:21
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha-upgrade October 1, 2024 15:23 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha October 1, 2024 15:25 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha-upgrade October 1, 2024 15:25 Destroyed
@aabouzaid aabouzaid force-pushed the 2339-identity-first-user-permissions branch from 4161bc4 to 930c5e3 Compare October 1, 2024 16:00
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha-upgrade October 1, 2024 16:02 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha October 1, 2024 16:04 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha-upgrade October 1, 2024 16:04 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-latest October 1, 2024 16:06 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-latest-upgrade October 1, 2024 16:06 Destroyed
@aabouzaid aabouzaid force-pushed the 2339-identity-first-user-permissions branch 2 times, most recently from 9393918 to 5abb92b Compare October 1, 2024 16:18
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha October 1, 2024 16:19 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha-upgrade October 1, 2024 16:20 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha October 1, 2024 16:23 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2395-intg-alpha-upgrade October 1, 2024 16:23 Destroyed
@aabouzaid aabouzaid force-pushed the 2339-identity-first-user-permissions branch from ddd2f7f to 05019f9 Compare October 1, 2024 16:41
@aabouzaid aabouzaid changed the title debug: Identity first user has no permissions fix: define Web Modeler Admin role in identity Oct 1, 2024
@aabouzaid aabouzaid requested a review from a team October 1, 2024 17:05
@aabouzaid aabouzaid marked this pull request as ready for review October 1, 2024 17:05
@aabouzaid aabouzaid merged commit 0c0263c into main Oct 1, 2024
18 of 19 checks passed
@aabouzaid aabouzaid deleted the 2339-identity-first-user-permissions branch October 1, 2024 17:06
@aabouzaid aabouzaid added the size/s Relative effort/time: Small label Oct 1, 2024
This was referenced Jan 23, 2025
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aabouzaid aabouzaid

Labels
component/identity size/s Relative effort/time: Small test-persistent Don't delete the Helm deployment created by the PR and use fixed names tool/github-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] Identity first user has no permissions - 8.6 alpha5
1 participant
@aabouzaid