Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove/rename deprecated helm values file keys #2615

Merged
merged 1 commit into from
Dec 13, 2024
Merged

refactor: remove/rename deprecated helm values file keys #2615

merged 1 commit into from
Dec 13, 2024

Conversation

aabouzaid
Copy link
Member

@aabouzaid aabouzaid commented Nov 26, 2024 •
edited
Loading

Which problem does the PR fix?

Task: #2589

What's in this PR?

Remove/rename deprecated helm values file keys.

Part of the change related to 8.7 refactorings and others related to deprecation from previous versions like renaming postgresql to webModelerPostgresql.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@aabouzaid aabouzaid self-assigned this Nov 26, 2024
@aabouzaid aabouzaid mentioned this pull request Nov 26, 2024
Closed
@aabouzaid aabouzaid added the test-persistent Don't delete the Helm deployment created by the PR and use fixed names label Dec 3, 2024
@aabouzaid aabouzaid force-pushed the 2589-remove-deprecated-keys branch 2 times, most recently from 4284744 to baf863d Compare December 3, 2024 15:21
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 3, 2024 15:22 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 3, 2024 15:23 In progress
@aabouzaid aabouzaid force-pushed the 2589-remove-deprecated-keys branch from baf863d to 61fec5a Compare December 3, 2024 15:39
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 3, 2024 15:41 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 3, 2024 15:42 In progress
@aabouzaid aabouzaid force-pushed the 2589-remove-deprecated-keys branch from 61fec5a to f24e79b Compare December 3, 2024 15:44
@aabouzaid aabouzaid force-pushed the 2589-remove-deprecated-keys branch from f24e79b to fa53f6d Compare December 3, 2024 15:49
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 3, 2024 15:50 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 3, 2024 15:50 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 3, 2024 15:53 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 3, 2024 15:54 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 3, 2024 15:56 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 3, 2024 15:56 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 3, 2024 16:27 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 3, 2024 16:27 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 3, 2024 16:30 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 3, 2024 16:30 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 3, 2024 16:33 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 3, 2024 16:33 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 3, 2024 17:13 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 3, 2024 17:13 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 3, 2024 17:24 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 3, 2024 17:27 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 12, 2024 23:42 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 12, 2024 23:50 In progress
@aabouzaid aabouzaid force-pushed the 2589-remove-deprecated-keys branch from ec81e3f to 0c3668f Compare December 13, 2024 00:12
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 13, 2024 00:14 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 13, 2024 00:14 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 13, 2024 00:24 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 13, 2024 00:31 In progress
@aabouzaid aabouzaid force-pushed the 2589-remove-deprecated-keys branch from 0c3668f to dd51d6f Compare December 13, 2024 00:46
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 13, 2024 00:48 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 13, 2024 00:49 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 13, 2024 00:56 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 13, 2024 01:03 In progress
@aabouzaid aabouzaid force-pushed the 2589-remove-deprecated-keys branch from dd51d6f to eee4bf1 Compare December 13, 2024 01:13
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2615-intg-alpha December 13, 2024 01:15 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 13, 2024 01:15 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 13, 2024 01:44 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-2615-intg-alpha-upgrade December 13, 2024 02:12 In progress
@aabouzaid aabouzaid added the size/m Relative effort/time: Medium label Dec 13, 2024
@aabouzaid
Copy link
Member Author

The failed upgrade will disappear once we merge as we test the upgrade from the snapshot.

@aabouzaid aabouzaid added cycle/alpha3 Tasks will be done in alpha3 cycle component/core labels Dec 13, 2024
@aabouzaid aabouzaid requested a review from a team December 13, 2024 12:19
@aabouzaid aabouzaid marked this pull request as ready for review December 13, 2024 12:19
@aabouzaid aabouzaid merged commit 9a7f111 into main Dec 13, 2024
19 of 21 checks passed
@aabouzaid aabouzaid deleted the 2589-remove-deprecated-keys branch December 13, 2024 12:20
jonathanlukas pushed a commit that referenced this pull request Dec 13, 2024
@aabouzaid @jonathanlukas
refactor: remove/rename deprecated helm values file keys (#2615)
6dd0e5e 
part of 8.7 alpha 3
This was referenced Jan 9, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aabouzaid aabouzaid

Labels
component/core component/identity component/web-modeler cycle/alpha3 Tasks will be done in alpha3 cycle size/m Relative effort/time: Medium test-persistent Don't delete the Helm deployment created by the PR and use fixed names
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aabouzaid