Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): small bug fixes and set correct values #2629

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix(core): small bug fixes and set correct values #2629

merged 3 commits into from
Dec 3, 2024
+141 −141

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Dec 3, 2024 •
edited
Loading

Which problem does the PR fix?

Wrong default configurations

What's in this PR?

Two fixes:

  1. The disk paths that were configured in the java opts were wrong. These name has been changed from zeebe to camunda.
  2. The metrics port is wrong. This was set to http. Previously http was configured to 9600. With the change to the core component http became 8080. The metrics are served at 9600, so this port must be changed.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@remcowesterhoud
fix: set correct paths
b5a1c31 
With the single Camunda application the folders are no longer called Zeebe. They are now called camunda.
@remcowesterhoud
fix: change port to 9600
b46ee87 
Zeebe exposes its metrics on the 9600 port. This is called the management port in the values. We should make sure to configure our service monitor to scrape metrics from this port. Not from 8080.
@remcowesterhoud remcowesterhoud changed the title Small bugfixes in the core component fix: Small bugfixes in the core component Dec 3, 2024
@remcowesterhoud remcowesterhoud changed the title fix: Small bugfixes in the core component fix: small bugfixes in the core component Dec 3, 2024
@aabouzaid aabouzaid added the size/xs Relative effort/time: Extra Small label Dec 3, 2024
@aabouzaid aabouzaid changed the title fix: small bugfixes in the core component fix(core): small bugfixes in the core component Dec 3, 2024
@aabouzaid aabouzaid changed the title fix(core): small bugfixes in the core component fix(core): small bug fixes and set correct values Dec 3, 2024
aabouzaid
aabouzaid approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@aabouzaid aabouzaid merged commit e53ceaf into main Dec 3, 2024
16 checks passed
@aabouzaid aabouzaid deleted the rw-fixes branch December 3, 2024 12:10
@aabouzaid aabouzaid added the version/8.7 Camunda applications/cycle version label Dec 3, 2024
@distro-ci distro-ci bot mentioned this pull request Dec 3, 2024
Merged
jonathanlukas pushed a commit that referenced this pull request Dec 13, 2024
@remcowesterhoud @distro-ci @jonathanlukas
fix(core): small bug fixes and set correct values (#2629)
0975275 
Co-authored-by: distro-ci[bot] <122795778+distro-ci[bot]@users.noreply.github.com>
This was referenced Jan 23, 2025
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabouzaid aabouzaid aabouzaid approved these changes

Assignees

@remcowesterhoud remcowesterhoud

Labels
component/monitoring size/xs Relative effort/time: Extra Small version/8.7 Camunda applications/cycle version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remcowesterhoud @aabouzaid