Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: envVar-identity-client-secret-not-passed #2700

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

hisImminence
Copy link
Contributor

Which problem does the PR fix?

related camunda/camunda#25904

What's in this PR?

Using IDENTITY_CLIENT_SECRET envVar in case CAMUNDA_IDENTITY_CLIENT_SECRET not set.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot added version/8.6 Camunda applications/cycle version component/identity labels Dec 17, 2024
@hisImminence
Copy link
Contributor Author

@hamza-m-masood I just pushed our change. Could you take over (I could not run the golden file updates...)

@hisImminence hisImminence changed the title fix-envVar-identity-client-secret chore(fix): fix-envVar-identity-client-secret Dec 17, 2024
@hisImminence hisImminence changed the title chore(fix): fix-envVar-identity-client-secret fix: envVar-identity-client-secret Dec 17, 2024
@hisImminence hisImminence changed the title fix: envVar-identity-client-secret fix: envVar-identity-client-secret-not-passed Dec 17, 2024
…-configmap' into chore(fix)-identity-configmap
@hisImminence hisImminence enabled auto-merge (squash) December 17, 2024 15:42
@hamza-m-masood hamza-m-masood self-assigned this Dec 17, 2024
@hisImminence hisImminence merged commit 75a1a16 into main Dec 17, 2024
16 checks passed
@hisImminence hisImminence deleted the chore(fix)-identity-configmap branch December 17, 2024 18:42
@aabouzaid
Copy link
Member

@hisImminence @hamza-m-masood, we probably need to do that for Alpha, too.

@hisImminence
Copy link
Contributor Author

@hisImminence @hamza-m-masood, we probably need to do that for Alpha, too.

Good point!
--> #2703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/identity version/8.6 Camunda applications/cycle version version:11.1.1 Issues and PRs related to chart version 11.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants