Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set identity client secret env var in alpha #2703

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

hisImminence
Copy link
Contributor

Which problem does the PR fix?

related to #2700

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@hisImminence hisImminence self-assigned this Dec 18, 2024
@github-actions github-actions bot added component/identity version/alpha Camunda applications/cycle version (this is a pointer to alpha) labels Dec 18, 2024
@hisImminence
Copy link
Contributor Author

@aabouzaid I am unsure if I can merge with the test failing. To me it seems the failing tests are accepted until the a stable alpha version is reached (I saw them failing e.g. in your PR too)? If its fine to merge, could you please merge for me as I am off the next weeks? 🙇‍♂️

@aabouzaid aabouzaid changed the title fix: set camunda-identity-client-secret in alpha fix: set identity client secret env var in alpha Dec 19, 2024
@aabouzaid aabouzaid merged commit d48086c into main Dec 19, 2024
8 of 12 checks passed
@aabouzaid aabouzaid deleted the add-identity-client-secret-fix-to-alpha branch December 19, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/identity version/alpha Camunda applications/cycle version (this is a pointer to alpha)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants