refactor: remove unused web-modeler config map entries #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
version/8.5
aabouzaid
changed the title
aabouzaid
approved these changes
Dec 19, 2024
|
@jfriedenstab Thanks for the PR 🙌 (the failed tests are unrelated to your change, so I will merge the PR). |
github-actions
bot
added
version:10.4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
-- no issue exists --
What's in this PR?
Removes
pusher-app-idandpusher-app-keyfromconfigmap-restapi.yamlandconfigmap-webapp.yaml. Both values are defined inconfigmap-shared.yamland read from there by all three Web Modeler components.Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: