[ISSUE] identity client-id for OIDC is not set when an existingSecret is used

[hamza-m-masood]

Describe the issue:

When global.identity.auth.[component].existingSecret.name is set in the values.yaml, the client-id in the identity configmap is not populated with a value.

This is because the if statement only allows string literal values and not existingSecrets:

camunda-platform-helm/charts/camunda-platform-8.5/templates/identity/configmap.yaml

Line 21 in c399f09

{{- if (tpl ( include "identity.authClientSecret" . ) .)}}

The above function only references the string literal:

camunda-platform-helm/charts/camunda-platform-8.5/templates/identity/_helpers.tpl

Line 219 in c399f09

{{- .Values.global.identity.auth.identity.existingSecret -}}

It does not reference .Values.global.identity.auth.identity.existingSecret.name as well to provide an existing k8s secret.

This is the case for 8.4 and above

Expected behavior:

I expect OIDC to function with existingSecrets and string literal values.

Logs:

Environment:

Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

• Platform:
• Helm CLI version:
• Chart version: 8.4,8.5,8.6
• Values file:

Tasks

Preview Give feedback

1. fix: client-secret should only be present when string literal provided for oidc #2733
   component/identity version/8.5 version/8.6 version/alpha version:10.4.7 version:11.1.1 +6

[hamza-m-masood]

It does not reference .Values.global.identity.auth.identity.existingSecret.name as well to provide an existing k8s secret.

Digging into this problem further, I realized that the configmap should not reference the above value, because secrets can't be referenced through a configmap. Secrets must be referenced through env vars. That is currently the case in our helm chart.
The problem still exists with the client-secret when an existing k8s secret is provided from the above value. Here is what the rendered configmap looks like:

    identity:
      url: "url"
      client-id: "test-id"
      client-secret: "map[name:test-k8s-secret]"

I will create a PR to fix this