Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public keyword from test methods #197

Closed
Tracked by #189
remcowesterhoud opened this issue Feb 18, 2022 · 0 comments · Fixed by #210
Closed
Tracked by #189

Remove public keyword from test methods #197

remcowesterhoud opened this issue Feb 18, 2022 · 0 comments · Fixed by #210

Comments

@remcowesterhoud
Copy link
Contributor

Description

We'd like to keep the scope of methods as small as possible. Even though these are tests it'd be nice to keep it in line with the rest of the code. JUnit 5 allows us to get rid of the public keyword. In some tests we don't have them, but in others we still do. We should get rid of all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant