Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and run tests on different OS's #143

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Jan 13, 2022

Description

Run the unit tests on different Operating Systems so we find OS specific bugs early.

Related issues

closes #142

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@remcowesterhoud remcowesterhoud force-pushed the 142-test-mutliple-oss branch 2 times, most recently from 804697a to 7e7c965 Compare January 13, 2022 09:32
@github-actions
Copy link

github-actions bot commented Jan 13, 2022

Unit Test Results

  84 files    84 suites   3m 5s ⏱️
185 tests 185 ✔️ 0 💤 0
555 runs  555 ✔️ 0 💤 0

Results for commit 043201f.

♻️ This comment has been updated with latest results.

@remcowesterhoud remcowesterhoud force-pushed the 142-test-mutliple-oss branch 9 times, most recently from dcd374e to e2dac78 Compare January 13, 2022 15:17
@remcowesterhoud remcowesterhoud marked this pull request as ready for review January 13, 2022 16:03
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I do have a question, but that's not blocking

.github/workflows/build-test.yml Show resolved Hide resolved
.github/workflows/build-test.yml Outdated Show resolved Hide resolved
@remcowesterhoud remcowesterhoud merged commit 3948722 into main Jan 14, 2022
@remcowesterhoud remcowesterhoud deleted the 142-test-mutliple-oss branch January 14, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run test on multiple OS's in workflow
2 participants