Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExecutorService for activating jobs #162

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Feb 2, 2022

Description

Activating jobs did not make use of the single threaded executor. This caused multiple threads to write at the same time, causing conflicts.

With this fix the synchronized is no longer necessary.

Related issues

closes #158

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Unit Test Results

  87 files    87 suites   3m 11s ⏱️
186 tests 186 ✔️ 0 💤 0
558 runs  558 ✔️ 0 💤 0

Results for commit 063d9f5.

♻️ This comment has been updated with latest results.

@remcowesterhoud
Copy link
Contributor Author

@Zelldon You were right about the activateJobs() method 👍. Would you mind reviewing this fix. I've also added a unit test which reproduces the issue.

Activating jobs did not make use of the single threaded executor. This caused multiple threads to write at the same time, causing conflicts.

With this fix the synchronized is no longer necessary.
Copy link
Member

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@remcowesterhoud remcowesterhoud merged commit 346a78a into main Feb 2, 2022
@remcowesterhoud remcowesterhoud deleted the 158-spring-zeebe-exceptions branch February 2, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions when using current test library within spring zeebe
2 participants