Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containerize in memory engine #177

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Containerize in memory engine #177

merged 4 commits into from
Feb 11, 2022

Commits on Feb 11, 2022

  1. feat: make engine runnable in a container 

    - Added a main class to make the engine executable
- Switched to a static port for the grpc server, so we always know what port we need to send the traffic to.
- Added a Dockerfile to make it possible to build a container.
    @remcowesterhoud
    remcowesterhoud committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    43b44ba View commit details
    Browse the repository at this point in the history

  2. ci: make build-test workflow reusable 

    Both the deploy workflow and the build/test workflow have to build and run the unit tests. By making the build/test workflow reusable we can call it in the deploy workflow.
    @remcowesterhoud
    remcowesterhoud committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    43cb00c View commit details
    Browse the repository at this point in the history

  3. ci: build and deploy engine as docker container 

    Added a job to the deployment pipeline which will build a container from the engine, and push it to dockerhub.

The container will default to the "latest" tag. If a new release is created in GitHub the name of the tag attached to this release will be used as the image tag, unless this release is a SNAPSHOT release.
    @remcowesterhoud
    remcowesterhoud committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    1febe64 View commit details
    Browse the repository at this point in the history

  4. fix: add slf4j dependency 

    One of the dependencies (zeebe-workflow-engine) requires this dependency. Running the engine without this will result in errors:

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
SLF4J: Failed to load class "org.slf4j.impl.StaticMDCBinder".
SLF4J: Defaulting to no-operation MDCAdapter implementation.
SLF4J: See http://www.slf4j.org/codes.html#no_static_mdc_binder for further details.

Adding this dependency resolves this issue and fixes the logging of the engine.
    @remcowesterhoud
    remcowesterhoud committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    9932fbe View commit details
    Browse the repository at this point in the history