Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runOnIdleState functionality #214

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Conversation

remcowesterhoud
Copy link
Contributor

Description

Run on idle state is a feature that we don't want to support at this time. It's best to keep the public interface as minimal as possible before the release. If it turns out users wish to use a functionality like these we can always re-add it later.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

Run on idle state is a feature that we don't want to support at this time. It's best to keep the public interface as minimal as possible before the release. If it turns out users wish to use a functionality like these we can always re-add it later.
@remcowesterhoud remcowesterhoud changed the title refactor: remove runOnIdleState Remove runOnIdleState functionality Feb 25, 2022
@github-actions
Copy link

github-actions bot commented Feb 25, 2022

Unit Test Results

124 files  124 suites   5m 57s ⏱️
321 tests 321 ✔️ 0 💤 0
772 runs  772 ✔️ 0 💤 0

Results for commit 93d379f.

♻️ This comment has been updated with latest results.

Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥇 I love deleted code ❤️‍🔥 LGTM

@remcowesterhoud remcowesterhoud merged commit 0f0f213 into main Feb 25, 2022
@remcowesterhoud remcowesterhoud deleted the remove-runonidle branch February 25, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants