Backport 301 to stable/8.0 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test checks if all the gateway endpoints are implemented. Since gRPC does not provide an interface which can force this during compile time we are at risk that updating the Zeebe version could result in ZPT not supporting all endpoints that can be triggered from the client. To circumvent this problem this test was created to make sure we implement all the methods gRPC expects us to. (cherry picked from commit 3b76c46)
(cherry picked from commit f8c31c6)
The response mapping has been moved from the GrpcResponseWriter to the GrpcToLogStreamGateway. The writer still contains the mapping functions, but they are called from the gateway. This change is necessary in order to support both the DeployProcessCommand as the DeployResourceCommand. In the writer we don't have any context about the request available. Therefore it is unknown which request we received, and also which response we should return. The mapping was based on the ValueType of the record which is the same for both of these commands. By letting the gateway decide which mapper should be used this problem has been resolved. At the point of entry of the request we will also decide which mapper should be used for the response. We nog longer need to decide the mapper base on the ValueType. (cherry picked from commit 5a8d1a7)
DeployProcessCommand is deprecated since Zeebe 8.0.0. In return a new command has been added to the client: DeployResourceCommand. This commit makes it possible to receive this command and return the appropriate response. (cherry picked from commit 2900923)
DeployCommand has been deprecated since Zeebe 8.0.0. We should use the new DeployResourceCommand as an alternative. (cherry picked from commit 66f6f49)
(cherry picked from commit ea3ef91)
(cherry picked from commit 0c94eae)
(cherry picked from commit 45b2973)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #301 to stable 8.0