Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zeebe Snapshot issues #680

Merged
2 commits merged into from
Mar 6, 2023
Merged

Fix Zeebe Snapshot issues #680

2 commits merged into from
Mar 6, 2023

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Mar 6, 2023

Description

  • The createEngineProcessors method was changed in Zeebe as part of Introduce GatewayStream API camunda#11889. One of the parameters was removed, this also needs to be removed here.
  • The broadcastSignal rpc was introduced in Zeebe. An implementation of this rpc is required here.

The createEngineProcessors method was changed in Zeebe. One of the parameters was removed, this also needs to be removed here.
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Test Results

  47 files  ±0    47 suites  ±0   2m 7s ⏱️ +19s
118 tests +1  117 ✔️ +1  1 💤 ±0  0 ±0 
377 runs  +3  374 ✔️ +3  3 💤 ±0  0 ±0 

Results for commit e70cd36. ± Comparison against base commit 32b3c6a.

♻️ This comment has been updated with latest results.

Adds the implementation for the signal broadcast rpc. This rpc needs to write a Signal BROADCAST command.
@remcowesterhoud remcowesterhoud changed the title Fix Snapshot Compilation issues Fix Zeebe Snapshot issues Mar 6, 2023
Copy link
Member

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@remcowesterhoud
Copy link
Contributor Author

bors merge

@ghost
Copy link

ghost commented Mar 6, 2023

Build succeeded:

@ghost ghost merged commit 4793632 into main Mar 6, 2023
@ghost ghost deleted the snapshot_fix branch March 6, 2023 09:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants