Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of can-view-scope is breaking the build 🚨 #637

Open
greenkeeper bot opened this issue Nov 28, 2018 · 9 comments
Open

An in-range update of can-view-scope is breaking the build 🚨 #637

greenkeeper bot opened this issue Nov 28, 2018 · 9 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Nov 28, 2018

The dependency can-view-scope was updated from 4.11.1 to 4.12.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

can-view-scope is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 7 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 28, 2018

After pinning to 4.11.1 your tests are passing again. Downgrade this dependency 📌.

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 29, 2018

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for initialValue should not emit ObservationRecords

Issue: #198

scopeKeyData.initialValue //-> should not emit a observationRecord 
Commits

The new version differs by 6 commits.

  • 80a1fa3 4.12.1
  • 7d2e6eb linting
  • 742532a Merge branch 'master' of github.com:canjs/can-view-scope
  • d67c9cb fixes #198
  • 2942dac Merge pull request #180 from canjs/greenkeeper/steal-2.0.0
  • 2c8acb9 chore(package): update steal to version 2.0.0

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Dec 6, 2018

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 8 commits.

  • c6abb74 4.13.0
  • 8c1c300 allows scope.args as a special key, replacing scope.arguments
  • 80a1fa3 4.12.1
  • 7d2e6eb linting
  • 742532a Merge branch 'master' of github.com:canjs/can-view-scope
  • d67c9cb fixes #198
  • 2942dac Merge pull request #180 from canjs/greenkeeper/steal-2.0.0
  • 2c8acb9 chore(package): update steal to version 2.0.0

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 25, 2019

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 17 commits.

  • ae105e5 4.13.1
  • 43bb8ba Merge pull request #202 from canjs/landscaper/qunit2
  • d8dacd3 Fix tests for QUnit 2
  • 6dd12aa Landscaper: QUnit2 upgrade
  • 5f6f517 Merge pull request #199 from canjs/greenkeeper/testee-0.9.0
  • 8a61ad0 Merge pull request #200 from canjs/landscaper/update-default-repos
  • ed7597f Update readme.md
  • cd8751c Update README generated by DoneJS
  • 607a562 chore(package): update testee to version 0.9.0
  • c6abb74 4.13.0
  • 8c1c300 allows scope.args as a special key, replacing scope.arguments
  • 80a1fa3 4.12.1
  • 7d2e6eb linting
  • 742532a Merge branch 'master' of github.com:canjs/can-view-scope
  • d67c9cb fixes #198

There are 17 commits in total.

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jul 9, 2019

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for Removing unnecessary properties from LetContext.prototype

Previously the LetContext had properties like one that would prevent you from ever using these keys in a Scope. This removes properties that are not needed from LetContext.prototype and only leaves required properties and Symbols.

#205

Commits

The new version differs by 5 commits.

  • 9d7d0c0 4.13.2
  • 2623264 Merge pull request #205 from canjs/let-context-prototype
  • dd84ece removing functions added by can-event-queue from LetContext.prototype
  • 28b3661 Merge pull request #203 from canjs/landscaper/travis-xenial
  • e8a4520 Migrate to xenial in travis

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 14, 2019

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 8 commits.

  • a5711cd 4.13.3
  • ec4011a Merge pull request #207 from canjs/setelement
  • a76ccbb Add implementation of can.setElement symbol
  • 9d7d0c0 4.13.2
  • 2623264 Merge pull request #205 from canjs/let-context-prototype
  • dd84ece removing functions added by can-event-queue from LetContext.prototype
  • 28b3661 Merge pull request #203 from canjs/landscaper/travis-xenial
  • e8a4520 Migrate to xenial in travis

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 19, 2019

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for Add links to scope.root deprecation warning

#209

Commits

The new version differs by 11 commits.

  • 535fc44 4.13.4
  • cc5bfcd Merge pull request #209 from canjs/add-deprecation-links-to-warning
  • b4dc4b1 Add links to scope.vm and scope.top in the scope.root warning
  • a5711cd 4.13.3
  • ec4011a Merge pull request #207 from canjs/setelement
  • a76ccbb Add implementation of can.setElement symbol
  • 9d7d0c0 4.13.2
  • 2623264 Merge pull request #205 from canjs/let-context-prototype
  • dd84ece removing functions added by can-event-queue from LetContext.prototype
  • 28b3661 Merge pull request #203 from canjs/landscaper/travis-xenial
  • e8a4520 Migrate to xenial in travis

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 19, 2019

Your tests are still failing with this version. Compare changes

Release Notes for Improve the “unable to find key” warning

Improves the missing key warning by logging of the property that can read for example:

var context = { foo: true };

var scope = new Scope(context);
var scopeKeyData = scope.computeData("foo.length", {
warnOnMissingKey: true
});

scopeKeyData.read(); // -> Unable to find key "foo.length". Found "foo" with value: true

Commits

The new version differs by 14 commits.

  • f1bb738 4.13.5
  • a2ab4f5 Merge pull request #208 from canjs/improve-unable-to-find-key-warning
  • 535fc44 4.13.4
  • cc5bfcd Merge pull request #209 from canjs/add-deprecation-links-to-warning
  • b4dc4b1 Add links to scope.vm and scope.top in the scope.root warning
  • 9d9c838 Improve missing key warning
  • a5711cd 4.13.3
  • ec4011a Merge pull request #207 from canjs/setelement
  • a76ccbb Add implementation of can.setElement symbol
  • 9d7d0c0 4.13.2
  • 2623264 Merge pull request #205 from canjs/let-context-prototype
  • dd84ece removing functions added by can-event-queue from LetContext.prototype
  • 28b3661 Merge pull request #203 from canjs/landscaper/travis-xenial
  • e8a4520 Migrate to xenial in travis

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 23, 2019

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for Handle undefined values on not found key warning

This fixes the not found key warning when a property is not defined in the scope:

var scope = new Scope({});

var scopeKeyData = scope.computeData("foo.length", {
warnOnMissingKey: true
});

scopeKeyData.read(); // -> Unable to find key "foo.length".

#210

Commits

The new version differs by 7 commits.

  • 66dd358 4.13.6
  • d5ccab2 Merge pull request #210 from canjs/handle-undefined-value-on-missing-key-warning
  • ba1494e Fix the test for undefined keys
  • f69a4b0 Fix the test
  • 94d0afa Don't warn when key is not defined
  • d83852c Add tests
  • 30a262a Handle undefined values on not found key warning

See the full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants