Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write out empty blocks #662

Open
justinbmeyer opened this issue Jan 14, 2019 · 3 comments
Open

Write out empty blocks #662

justinbmeyer opened this issue Jan 14, 2019 · 3 comments

Comments

@justinbmeyer
Copy link
Contributor

image

Angular does this for its if directive.
@matthewp
Copy link
Contributor

Aren't these written out as textnodes currently? Is this issue to replace that with comments?

@justinbmeyer
Copy link
Contributor Author

Yeah, it’s nicer debug experience IMO. You can see something.

@matthewp
Copy link
Contributor

Ok, I agree then. This is what portals does in the spot within the template where it was used. I used canReflect.getName() on the observable so it looks like this:

screen shot 2019-01-14 at 4 32 57 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinbmeyer @matthewp