Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING.md file #114

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Add CONTRIBUTING.md file #114

merged 3 commits into from
Oct 4, 2023

Conversation

ColmBhandal
Copy link
Contributor

No description provided.

@ColmBhandal ColmBhandal requested a review from a team as a code owner September 28, 2023 15:25
orfeas-k
orfeas-k previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@orfeas-k orfeas-k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, also this needs rebase

CONTRIBUTING.md Outdated Show resolved Hide resolved
i-chvets
i-chvets previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@i-chvets i-chvets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ColmBhandal ColmBhandal changed the title Contributing file Add CONTRIBUTING.md file Oct 4, 2023
@ColmBhandal @orfeas-k
Update CONTRIBUTING.md
c97ad9f 
Co-authored-by: Orfeas Kourkakis <orfeas.kourkakis@canonical.com>
@ColmBhandal ColmBhandal dismissed stale reviews from i-chvets and orfeas-k via c97ad9f October 4, 2023 14:08
@ColmBhandal ColmBhandal merged commit 0f11779 into main Oct 4, 2023
6 checks passed
@ColmBhandal ColmBhandal deleted the KF-4484-Admission-Webhook-Contributing-Doc branch October 4, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orfeas-k orfeas-k orfeas-k approved these changes

@i-chvets i-chvets i-chvets left review comments

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ColmBhandal @orfeas-k @i-chvets