Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle for 1.9 is missing the branch gh metadata #1037

Closed
Tracked by #1032
kimwnasptd opened this issue Aug 23, 2024 · 1 comment · Fixed by #1039
Closed
Tracked by #1032

Bundle for 1.9 is missing the branch gh metadata #1037

kimwnasptd opened this issue Aug 23, 2024 · 1 comment · Fixed by #1039
Labels
bug Something isn't working

Comments

@kimwnasptd
Copy link
Contributor

kimwnasptd commented Aug 23, 2024

Bug Description

This was found while working on #1036

The previous bundles for 1.8 had _github_repo_branch metadata keys in the bundle, in order for the scanning scripts to gather the images from the corresponding branches.
https://github.com/canonical/bundle-kubeflow/blob/main/releases/1.8/stable/kubeflow/bundle.yaml#L11

But for 1.9 everything is set to main. This means that all scripts now are going to be using the tools/get-images.sh scripts from the main branches of the charms

To Reproduce

Run the image gathering script from airgap for the 1.9 bundle. It will end up showing images from the main branches

Environment

Current main
https://github.com/canonical/bundle-kubeflow/tree/b2269189231aea9a1c594def3bd92549ebb3ee0d

Relevant Log Output

bundle: kubernetes
name: kubeflow
docs: https://discourse.charmhub.io/t/3749
applications:
  admission-webhook:
    charm: admission-webhook
    channel: 1.9/stable
    trust: true
    scale: 1
    _github_repo_name: admission-webhook-operator
    _github_repo_branch: main
  argo-controller:
    charm: argo-controller
    channel: 3.4/stable
    trust: true
    scale: 1
    _github_repo_name: argo-operators
    _github_repo_branch: main
...

Additional Context

No response

@kimwnasptd kimwnasptd added the bug Something isn't working label Aug 23, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6147.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant