Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support watchNamespace flag for controller #50

Open
jayesh-srivastava opened this issue Mar 31, 2024 · 1 comment · May be fixed by #53
Open

Support watchNamespace flag for controller #50

jayesh-srivastava opened this issue Mar 31, 2024 · 1 comment · May be fixed by #53

Comments

@jayesh-srivastava
Copy link

The current implementation of control-plane-microk8s controller does not support watchNamespace flag. This won't have any affect on clusters deployed using upstream's deployment model as controllers and webhooks are a singleton instance.
But in many cases where controllers and webhooks are separate entities, this can create issues when having a separate controller per namespace as then there will be no restriction for the controller to watch objects in its namespace only. This can create an instance of multiple reconcilers from different namespaces creating resources in different namespaces.

Supporting watchNamespace will be helpful for downstream and will assist in bringing this provider, more in-line with other CAPx providers.

@jayesh-srivastava
Copy link
Author

/assign

@jayesh-srivastava jayesh-srivastava linked a pull request Mar 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant