Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer --use-lxd over CRAFT_BUILD_ENVIRONMENT #354

Open
mr-cal opened this issue May 31, 2024 · 1 comment
Open

Prefer --use-lxd over CRAFT_BUILD_ENVIRONMENT #354

mr-cal opened this issue May 31, 2024 · 1 comment
Labels
Enhancement New feature or request triaged

Comments

@mr-cal
Copy link
Contributor

mr-cal commented May 31, 2024

What needs to get done

This function needs to check if --use-lxd was provided.

Why it needs to get done

The following commands will run locally, rather than in a container:

CRAFT_BUILD_ENVIRONMENT=host testcraft pack --use-lxd
# for core24 snaps
SNAPCRAFT_BUILD_ENVIRONMENT=host snapcraft pack --use-lxd

This is wrong because command line arguments should take priority over environment variables

@mr-cal mr-cal added Enhancement New feature or request triaged labels May 31, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-2982.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

1 participant