Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent failure on certain store issues #751

Open
lengau opened this issue Jun 7, 2024 · 0 comments
Open

Silent failure on certain store issues #751

lengau opened this issue Jun 7, 2024 · 0 comments
Labels
Bug Something isn't working

Comments

@lengau
Copy link
Contributor

lengau commented Jun 7, 2024

Bug Description

During transient store issues (i.e. 500-series HTTP errors), we don't error out as expected.

To Reproduce

Set up a fake store 🙃 that always returns 500 errors and run craft_parts.packages.snaps.SnapPackage("any-name").get_store_snap_info()

Expected result:

Errors out when getting the info

Actual result:

Just returns no snap info

part yaml

plugin: go
source: .
source-type: local    
build-snaps:
 - go/1.21/stable

Relevant log output

[From snapcraft]

2024-05-27 21:41:21.556 :: 2024-05-27 21:34:40.843 ignore patterns: ['*.snap']
2024-05-27 21:41:21.556 :: 2024-05-27 21:34:40.843 Installing build-packages
2024-05-27 21:41:21.556 :: 2024-05-27 21:34:40.844 Installing build-snaps
2024-05-27 21:41:21.556 :: 2024-05-27 21:35:20.892 The http error when checking the store for core22 is 500 (retries left 5)
2024-05-27 21:41:21.556 :: 2024-05-27 21:36:00.933 The http error when checking the store for core22 is 500 (retries left 4)
2024-05-27 21:41:21.556 :: 2024-05-27 21:36:40.967 The http error when checking the store for core22 is 500 (retries left 3)
2024-05-27 21:41:21.556 :: 2024-05-27 21:37:20.995 The http error when checking the store for core22 is 500 (retries left 2)
2024-05-27 21:41:21.556 :: 2024-05-27 21:38:01.017 The http error when checking the store for core22 is 500 (retries left 1)
2024-05-27 21:41:21.556 :: 2024-05-27 21:38:41.043 The http error when checking the store for go is 500 (retries left 5)
2024-05-27 21:41:21.556 :: 2024-05-27 21:39:21.073 The http error when checking the store for go is 500 (retries left 4)
2024-05-27 21:41:21.556 :: 2024-05-27 21:40:01.086 The http error when checking the store for go is 500 (retries left 3)
2024-05-27 21:41:21.556 :: 2024-05-27 21:40:41.102 The http error when checking the store for go is 500 (retries left 2)
2024-05-27 21:41:21.556 :: 2024-05-27 21:41:21.116 The http error when checking the store for go is 500 (retries left 1)
2024-05-27 21:41:21.556 :: 2024-05-27 21:41:21.121 verify plugin environment for part '********'
2024-05-27 21:41:21.556 :: 2024-05-27 21:41:21.124 plugin validation environment: # Environment
2024-05-27 21:41:21.556 :: ## Application environment
// continues as normal, errors out because we don't have go
@lengau lengau added the Bug Something isn't working label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant