Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rock for dex v2.36.0 #1

Merged
merged 2 commits into from
Dec 7, 2023
Merged

add rock for dex v2.36.0 #1

merged 2 commits into from
Dec 7, 2023

Conversation

ca-scribner
Copy link
Contributor

@ca-scribner ca-scribner commented Dec 5, 2023 •
edited
Loading

This adds a rock for dex v2.36.0 which is based on https://github.com/dexidp/dex/blob/v2.36.0/Dockerfile

Notes to reviewers

  • image should be executable via docker run imagename:tag and should start exactly like the upstream image (docker run dexidp/dex:v2.31.2)

@ca-scribner ca-scribner requested a review from a team as a code owner December 5, 2023 20:35
@ca-scribner ca-scribner mentioned this pull request Dec 5, 2023
Closed
3 tasks
NohaIhab
NohaIhab approved these changes Dec 7, 2023
View reviewed changes
Copy link

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested by using the image in dex-auth charm, confirmed that login functionality works
lgtm

@ca-scribner ca-scribner merged commit dc90f24 into main Dec 7, 2023
@ca-scribner ca-scribner deleted the add-dex-auth-rock branch December 7, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NohaIhab NohaIhab NohaIhab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ca-scribner @NohaIhab