Configure envoy-operator for CKF 1.8 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates tox.ini's `update-requirements` as described in canonical/argo-operators#100. Ref canonical/kubeflow-ci#59
Modify some values in order to follow upstream configuration from file `third_party/metadata_envoy/envoy.yaml` in pipelines repo.
- Use constant for mlmd charm name. - Use latest/edge channel for mlmd. - Use latest/stable channel for other charms. - Remove redundant assertion and add `idle_period` to the one left.
Remove assertion that doesn't make sense anymore. This PR changed the relations between charms resulting in different result from Prometheus endpoint.
|
Pushed also a commit to remove one assertion in the Prometheus integration test. We still have other assertions after this one that assert the request's data. I think the GET request to Prometheus endpoint returns different results due to the fact that the PR changed the relations and bumped charms to newer version. |
DnPlas
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update-requirementsas described inchange tox for update dependencies argo-operators#100.
third_party/metadata_envoy/envoy.yaml in pipelines repo