-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: project structure refactor #318
Merged
matthew-hagemann
merged 16 commits into
canonical:main
from
matthew-hagemann:project-structure-refactor
Nov 18, 2024
Merged
refactor: project structure refactor #318
matthew-hagemann
merged 16 commits into
canonical:main
from
matthew-hagemann:project-structure-refactor
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reminder for myself and/or @d-loose: we'll need to update the config in weblate when this merges. |
matthew-hagemann
changed the title
Project structure refactor
refactor: project structure refactor
Nov 18, 2024
d-loose
previously approved these changes
Nov 18, 2024
matthew-hagemann
force-pushed
the
project-structure-refactor
branch
from
November 18, 2024 14:28
f3012c6
to
071f614
Compare
d-loose
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at refactoring the file structure to match our new project layout without moving any code around.
Some things to note in
firmware_updater
:pages/device_store
exportsDeviceStore
used in all pagespages/device_model
exportsDeviceModel
used in all pages and in multiple widgetslib/app/fwupd_x.dart
. It is used in multiple pages, services and widgets, as islib/app/fwupd_notifier
, which made it feel like the belonged inapp
. Perhapscommon
?