Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: project structure refactor #318

Merged

Conversation

matthew-hagemann
Copy link
Contributor

@matthew-hagemann matthew-hagemann commented Nov 15, 2024

First pass at refactoring the file structure to match our new project layout without moving any code around.

Some things to note in firmware_updater:

  • Allot code is shared across multiple files, making me decided not to create sub directories within pages, services etc. For example:
    • pages/device_store exports DeviceStore used in all pages
    • pages/device_model exports DeviceModel used in all pages and in multiple widgets
  • I am not 100% sure where to place lib/app/fwupd_x.dart. It is used in multiple pages, services and widgets, as is lib/app/fwupd_notifier, which made it feel like the belonged in app. Perhaps common?
  • Not all names align with our new naming scheme. Should I do some name refactoring aswell?

@matthew-hagemann matthew-hagemann marked this pull request as ready for review November 15, 2024 13:56
@sminez
Copy link
Contributor

sminez commented Nov 15, 2024

Reminder for myself and/or @d-loose: we'll need to update the config in weblate when this merges.

@matthew-hagemann matthew-hagemann changed the title Project structure refactor refactor: project structure refactor Nov 18, 2024
d-loose
d-loose previously approved these changes Nov 18, 2024
@matthew-hagemann matthew-hagemann merged commit 8a89054 into canonical:main Nov 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants