tests: Add basic IP allocation tests #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markylaing
changed the title
|
Failing here: https://github.com/canonical/lxd-ci/actions/runs/9447367697/job/26019039138?pr=186#step:7:1615 This should pass when edge contains canonical/lxd#13575 |
simondeziel
reviewed
Jun 10, 2024
Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing
force-pushed
the
allocated-ips
branch
from
9c32d38
to
b66eb68
Compare
tomponline
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some basic tests for automatic allocation of IP addresses for OVN network forwards and load balancers.
I've found it difficult to make these tests more extensive because the allocated IPs are random but the tests rely on hardcoded IPs. To avoid collisions we need to keep track of whether or not forwards/load balancers have been created with allocated IPs (by the API extension) and delete them before creating new forwards/load balancers with a fixed IP on any network using the same uplink.
I think it's fine for now to just ensure they can be created/deleted and that new ones can't be created with the same IP. There is no difference in code path/functionality between allocated/fixed IP after initial creation.