Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mistake in restricted.containers.privilege documentation #12591

Closed
p-ouellette opened this issue Dec 4, 2023 · 2 comments · Fixed by #12604
Closed

doc: mistake in restricted.containers.privilege documentation #12591

p-ouellette opened this issue Dec 4, 2023 · 2 comments · Fixed by #12604
Assignees
Labels
Bug Confirmed to be a bug Documentation Documentation needs updating

Comments

@p-ouellette
Copy link

When set to isolated, this option prevents setting security.privileged and security.idmap.isolated to true.

I think that should say something like "When set to isolated, security.idmap.isolated must be set to true if security.privileged is set to true."


Document: reference/projects.md

@tomponline
Copy link
Member

I agree the docs as they are currently could certainly be clarified.
However the proposed change here is not correct.

When security.privileged is enabled, this disables the user namespace which will have the effect of ignoring the security.idmap and raw.idmap themed settings.

The project's restricted.containers.privilege=isolated means to only allow containers to run with their own isolated idmap range (rather than a shared range), and should be used without enabling security.privileged.

My understanding is that the reason why security.privileged and the idmap related settings can be enabled at the same time is to accommodate using the idmap settings in a profile and then selectively enabling privileged mode on just selected container(s).

However I think we can do better around validation of security.privileged and the idmap settings when both are coming from a profile.

@tomponline tomponline added Bug Confirmed to be a bug Documentation Documentation needs updating labels Dec 4, 2023
@p-ouellette
Copy link
Author

However the proposed change here is not correct.

Yes, I misread the code. I think this would be accurate: "When set to isolated, security.idmap.isolated must be set to true and security.privileged cannot be set to true." As it is now, I understood it to mean that both options must not be set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed to be a bug Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants