Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/instances: add UI instructions #12237

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

ru-fu
Copy link
Contributor

@ru-fu ru-fu commented Sep 11, 2023

Add instructions for how to manage and configure instances through the UI.
This is part of a PoC for how we can present instructional content for different clients.

@github-actions github-actions bot added the Documentation Documentation needs updating label Sep 11, 2023
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you. I added some suggestions. Only one thing is off: custom configuration is persisted by the UI. The limitation is around the changed and not persisted content of the YAML editor.

doc/howto/instances_configure.md Outdated Show resolved Hide resolved
doc/howto/instances_manage.md Outdated Show resolved Hide resolved
doc/howto/instances_manage.md Show resolved Hide resolved
doc/images/UI/limits_memory_example.png Outdated Show resolved Hide resolved
doc/howto/instances_configure.md Outdated Show resolved Hide resolved
doc/howto/instances_manage.md Outdated Show resolved Hide resolved
doc/howto/instances_manage.md Show resolved Hide resolved
doc/howto/instances_manage.md Outdated Show resolved Hide resolved
@ru-fu
Copy link
Contributor Author

ru-fu commented Sep 12, 2023

Thanks @edlerd ! Updated as suggested. :)

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes - everything reads very good and correct now. Just a tiny change request below.

doc/howto/instances_manage.md Outdated Show resolved Hide resolved
Add instructions for how to manage and configure instances through
the UI.
This is part of a PoC for how we can present instructional content
for different clients.

Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
@tomponline tomponline merged commit 9f1e8f4 into canonical:main Sep 12, 2023
24 checks passed
@ru-fu ru-fu deleted the LXD-357-ui-instructions branch September 12, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants