Small ISO workaround #12245
Merged
Small ISO workaround #12245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cb27843 due to too frequent failed CI runs ending like: > + truncate -s 5MiB foo.iso > + basename /home/runner/work/lxd/lxd/test/tmp.8tG/z2ZzFIbzM > + lxc storage volume import lxdtest-z2ZzFIbzM-dir ./foo.iso iso1 > + set +x > + timeout --foreground 120 /home/runner/go/bin/lxc storage volume import lxdtest-z2ZzFIbzM-dir ./foo.iso iso1 --verbose > > Importing custom volume: 2% (1.26GB/s) > ... > > ==> TEST DONE: storage local volume handling > ==> Test result: failure Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
This reverts commit 16f7e1a due to too frequent failed CI runs ending like: > + lxc storage volume import lxdtest-haC ./foo.img --type=iso foobar > + set +x > + timeout --foreground 120 /home/runner/go/bin/lxc storage volume import lxdtest-haC ./foo.img --type=iso foobar --verbose > > Importing custom volume: 2% (2.52GB/s) > ... > > ==> TEST DONE: storage volume import > ==> Test result: failure Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
force-pushed
the
small-iso-workaround
branch
from
53e5c95
to
97a768b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12113, all ISO files were shrunk down to 8MiB. Smaller sizes (1, 2 and 4MiB) were tried but caused increased failure rate in the
migration,storage_local_volume_handlingandstorage_volume_importtest cases.It seems that even 8MiB is too small causing those tests to fail and account for ~25% of all the failures. Until the root cause can be find and fixed, it's better to revert those commits.