github: only try to upload differential shellcheck result if it ran #12324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
|
@tomponline this is meant to fix https://github.com/simondeziel/lxd/actions/runs/6316206699/job/17150326616 but we'll only know if it worked once you merge it because it should then not try to upload any differential shellcheck results since the differential shellcheck check wouldn't run. |
tomponline
approved these changes
Sep 26, 2023
MusicDin
approved these changes
Sep 26, 2023
|
What is the artifact upload for anyway? Have we used this elsewhere before? |
|
The artifacts are what contains the analysis result that I think are used by the bot to look over and put comments in the PR. lxd-ci uses that. https://github.com/redhat-plumbers-in-action/differential-shellcheck#outputs doesn't clearly explain it. |
|
That makes sense thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.