config: Ensure config key values are reset to their default #12483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
reviewed
Oct 30, 2023
When unsetting a config key, the value should be reset correctly to its default value. Fixes canonical#12478 Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
monstermunchkin
force-pushed
the
issues/12478-default-bool
branch
from
b782eee
to
b19deff
Compare
monstermunchkin
changed the title
simondeziel
previously approved these changes
Oct 30, 2023
|
@monstermunchkin I forgot to ask but I think that's quick an easy to add a test for it as well. |
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
simondeziel
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unsetting a config key, the value should be reset correctly to
the default value.
Fixes #12478