lxd/instance/drivers/driver_qemu: force 4MB UEFI firmware in snap #12515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihalicyn
added a commit
to mihalicyn/lxd-pkg-snap
that referenced
this pull request
Nov 7, 2023
canonical/lxd#12515 Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
MusicDin
reviewed
Nov 7, 2023
MusicDin
reviewed
Nov 7, 2023
gabrielmougard
previously approved these changes
Nov 8, 2023
mihalicyn
force-pushed
the
drop_edk2_2mb_version
branch
from
03f4ffa
to
0663354
Compare
yes, and goal of this PR is to make it work without bothering users. Idea is to silently replace |
tomponline
reviewed
Nov 20, 2023
tomponline
reviewed
Nov 20, 2023
mihalicyn
force-pushed
the
drop_edk2_2mb_version
branch
from
0663354
to
87899ef
Compare
…rom setupNvram Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
mihalicyn
force-pushed
the
drop_edk2_2mb_version
branch
from
87899ef
to
0c5ec12
Compare
tomponline
reviewed
Nov 21, 2023
- If VM uses 2 meg firmware, we force NVRAM cleanup and regeneration and then make it to use 4 meg version. - start using 4 meg firmware in the checkFeatures(...) Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
mihalicyn
force-pushed
the
drop_edk2_2mb_version
branch
from
0c5ec12
to
ac76c1c
Compare
tomponline
reviewed
Nov 21, 2023
tomponline
approved these changes
Nov 21, 2023
mihalicyn
added a commit
to mihalicyn/lxd-pkg-snap
that referenced
this pull request
Nov 21, 2023
canonical/lxd#12515 Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force 4MB edk2 firmware for existing VMs with 2MB firmware