lxc: Use volume copy when moving to target project

[roosterfish]

This fixes a regression introduced in #12348. When the target project flag is set don't use the function for renaming volumes.

Fixes #12518

[MusicDin]

I see all other tests use "lxdtest-$(basename "${LXD_DIR}")-${driver}1" as a pool name, but could we store that in a variable to make the tests easier to read?

proj="lxdtest-$(basename "${LXD_DIR}")-${driver}"
pool="lxdtest-$(basename "${LXD_DIR}")-${driver}1"

lxc project create "${proj}"
lxc storage colume move "${pool}/vol1" "${pool}/vol1" --project default --target-project "${proj}"
...

Just a suggestion, otherwise LGTM.

[roosterfish]

@MusicDin changed to make it more readable.

[MusicDin]

@roosterfish thanks, looks much better. Should we change that for an entire test, or is this out of scope? I think it would improving readability of the codebase. What are your thoughts?

[roosterfish]

@roosterfish thanks, looks much better. Should we change that for an entire test, or is this out of scope? I think it would improving readability of the codebase. What are your thoughts?

@MusicDin I have now restructured the test suite. Let me know what you think.

[MusicDin]

Looks good to me. However, do you have any idea why Ceph test is failing?

[roosterfish]

Looks good to me. However, do you have any idea why Ceph test is failing?

Not really. I have triggered a rerun to be sure.

[roosterfish]

Found the issue, I have replaced a wrong variable which let the test to not skip cephfs in the loop. This is fixed now, all tests are passing.

[MusicDin]

Nice. Looks much cleaner now :)