Optionally create entities for cephfs storage pool

[masnax]

Adds the config keys:

• cephfs.create_missing
  • Creates the filesystem and the necessary data and metadata OSD pools if they don't exist
• cephfs.osd_pg_num
  • Specifies the pg_num for the OSD pools that are created with create_missing. If unset, will default to 32.
• cephfs.meta_pool
• cephfs.data_pool
  • Specifies the respective names of the metadata and data OSD pools to expect if we need to create the filesystem with create_missing. If these OSD pools already exist, then they will be re-used, otherwise they will be created.

If any of the above keys are set but the fs already exists, then the creation will error out.

[tomponline]

A few minor code style changes and improvements to error handling.

[masnax]

@tomponline I'll put a pause on this until I've sorted out your comments which apply to the ceph driver as well. That way the two ceph drivers can be a bit more streamlined.

[tomponline]

@masnax any news on progress for this one?

[masnax]

@masnax any news on progress for this one?

There's a lot of usages of TryRunCommand throughout the storage drivers that I'm trying to deduce the purpose of, so that's what's been halting progress here. I suppose in the mean time I can just update cephfs and make an issue for cleaning up the storage drivers.

[tomponline]

@masnax any news on progress for this one?

There's a lot of usages of TryRunCommand throughout the storage drivers that I'm trying to deduce the purpose of, so that's what's been halting progress here. I suppose in the mean time I can just update cephfs and make an issue for cleaning up the storage drivers.

yes please

[masnax]

@tomponline OK this has now been updated with the following:

• The OSD Pool and FS creation will now be reverted if there's an error during creation.
• The cephfs helpers for checking existence of entities now properly differentiate between exit codes.
• TryRunCommand is not used for create/delete operations.
• API extension has been renamed.

[tomponline]

LGTM thanks!

[tomponline]

Tests failing

 lxc storage delete cephfs2
+ set +x
+ timeout --foreground 120 /home/runner/go/bin/lxc storage delete cephfs2 --verbose
Storage pool cephfs2 deleted
+ ceph fs fail cephfs
Error ENOENT: Filesystem not found: 'cephfs'
+ cleanup
+ set +ex