Use rsync flags consistently for local and remote copy #12715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rsync
--checksum
flag has a history in LXD which ultimately led to the fact that remote container copies can be faster than local ones:TODO: Not sure we need this option
.lxd/rsync.go
without any changesToday rsync still doesn't check for nanoseconds by default but you can now set
--modify-window=-1
to a negative value which will cause a check for nanoseconds starting from version 3.1.3 (fromman rsync
):The LXD snap uses rsync version 3.2.7. This was discovered in #12668