Remove deprecated instance config option limits.network.priority #12735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iority Signed-off-by: Din Music <din.music@canonical.com>
…k device Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
…r keys Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
tomponline
reviewed
Jan 18, 2024
| success := false | ||
| var lastError error | ||
| for _, netif := range netifs { | ||
| err = cg.SetNetIfPrio(fmt.Sprintf("%s %d", netif.Name, networkInt)) |
There was a problem hiding this comment.
Do we also need to remove this function?
There was a problem hiding this comment.
Do you mean cg.SetNetIfPrio? I've removed it because it was no longer in use
There was a problem hiding this comment.
So you have, i missed it, sorry.
tomponline
approved these changes
Jan 18, 2024
simondeziel
added a commit
to simondeziel/lxd-ci
that referenced
this pull request
Feb 27, 2024
Support for this was removed in canonical/lxd#12735 to address canonical/lxd#12419 Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
added a commit
to simondeziel/lxd-ci
that referenced
this pull request
Feb 27, 2024
Support for this was removed in canonical/lxd#12735 to address canonical/lxd#12419 `limits.network.priority` was replace with a per-NIC `limits.priority` that's compatble with cgroup1 and cgroup2 but that's already tested in tests/network-bridge-firewall. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12419