Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: fix branch target name/version extraction logic #13110

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

simondeziel
Copy link
Member

This should handle stable-NM.XYZ instead of only stable-X.Y

This should handle stable-NM.XYZ instead of only stable-X.Y

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel marked this pull request as ready for review March 12, 2024 13:16
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be backported to 5.x branches too please.

@tomponline tomponline merged commit 2fed30b into canonical:main Mar 12, 2024
27 checks passed
@simondeziel simondeziel deleted the branch-target-multi-digits branch March 12, 2024 13:28
@simondeziel
Copy link
Member Author

simondeziel commented Mar 12, 2024

This will need to be backported to 5.x branches too please.

Technically, we only need it for stable-5.21 as stable-5.0 wouldn't run into the issue :)
I'll open PRs anyway, for consistency and will also fix lxd-pkg-snap.git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants