-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch: Fix patches that incorrectly depend on cluster member being leader #13189
Conversation
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
@tomponline do you want me to fix it also for I put the reworked patches alongside there parents to keep them together and not at the end of the file. |
No, lets leave that one well alone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patches var definition says:
Only append to the patches list, never remove entries and never re-order them.
Supersedes patchStorageRenameCustomISOBlockVolumes by using the new patch cluster member selection Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Supersedes patchStorageUnsetInvalidBlockSettings by using a single idempotent SQL query Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
84d0a10
to
87c1783
Compare
Mhh ok haven't seen this, it felt wrong doing it but I thought if the original patch gets emptied out, and its replacement is executed at the end of the list, maybe it might cause side effects with other patches. |
This PR is a follow up on #13162 to fix the leader election also for
patchStorageRenameCustomISOBlockVolumes
andpatchStorageUnsetInvalidBlockSettings
.A new function
selectedPatchClusterMember
is added which offers a deterministic approach to select a single member across the cluster which is eligible to apply the patch. For example this is necessary for the patchpatchStorageRenameCustomISOBlockVolumes
which interferes with the storage subsystem.The patch
patchStorageUnsetInvalidBlockSettings
is superseded by a single idempotent query that can now run multiple times on all cluster members.