DB: Remove ErrAlreadyDefined sentinel error.
#13252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error is imported by the `lxd/request` package so that it can convert it to an `http.StatusConflict` on a call to `response.SmartError`. Other applications are using the `lxd/request` package. Removing this error prevents the import of `lxd/db` into `lxd/request` and therefore prevents the import of `lxd/db` into downstream repositories. Signed-off-by: Mark Laing <mark.laing@canonical.com>
This will be caught by `response.SmartError` equivalently to return a 409 to the caller. Additionally, error messages are updated to be more descriptive. Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
tomponline
reviewed
Apr 3, 2024
tomponline
reviewed
Apr 3, 2024
markylaing
force-pushed
the
db-err-already-defined
branch
from
92aceaa
to
b7138ba
Compare
tomponline
reviewed
Apr 3, 2024
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing
force-pushed
the
db-err-already-defined
branch
from
b7138ba
to
df393a8
Compare
|
Now failing unit tests. Missed some references. |
Signed-off-by: Mark Laing <mark.laing@canonical.com>
tomponline
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is imported by the
lxd/requestpackage so that it canconvert it to anhttp.StatusConflicton a call toresponse.SmartError. Other applications are using thelxd/requestpackage. Removing this error prevents the import oflxd/dbintolxd/requestand therefore prevents the import oflxd/dbinto downstream repositories.Unblocks canonical/microcluster#97