lxd/image: set Cached: false for pre-existing cached image
#13296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmougard
force-pushed
the
fix/set-cached-false-pre-existing-image
branch
3 times, most recently
from
3330c36
to
5184468
Compare
|
test failures |
gabrielmougard
force-pushed
the
fix/set-cached-false-pre-existing-image
branch
from
5184468
to
7c9eb3d
Compare
|
@tomponline tests are passing now |
tomponline
reviewed
Apr 10, 2024
tomponline
reviewed
Apr 10, 2024
tomponline
reviewed
Apr 10, 2024
tomponline
reviewed
Apr 10, 2024
gabrielmougard
force-pushed
the
fix/set-cached-false-pre-existing-image
branch
from
7c9eb3d
to
0980bc7
Compare
tomponline
reviewed
Apr 11, 2024
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
…entually uncache the image If the image already exists, is cached and that it is requested to be downloaded from an explicit `image copy` operation, then disable its `cache` parameter so that it won't be candidate for auto removal. Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Now, only `imgPostRemoteInfo()` and `imgPostURLInfo()` calling `ImageDownload` are used for an explicit image copy operation. Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
gabrielmougard
force-pushed
the
fix/set-cached-false-pre-existing-image
branch
from
0980bc7
to
35f93bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13271