Optimize database calls on storagePoolVolumesGet
#13349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamistao
force-pushed
the
optimize_database_calls
branch
8 times, most recently
from
fde2491
to
39cf55f
Compare
roosterfish
requested changes
Apr 19, 2024
hamistao
force-pushed
the
optimize_database_calls
branch
5 times, most recently
from
1bc401e
to
c318c49
Compare
|
@roosterfish sorry about that, now I believe everything is in order. |
tomponline
reviewed
Apr 23, 2024
|
Any update on this @hamistao ? |
…olID` Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
hamistao
force-pushed
the
optimize_database_calls
branch
from
c318c49
to
9535027
Compare
tomponline
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize database calls on
storagePoolVolumesGetas discussed @tomponline @markylaing @roosterfish