Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/ovn: include networking architecture figures #13356

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

ru-fu
Copy link
Contributor

@ru-fu ru-fu commented Apr 19, 2024

Add and describe the figures

@ru-fu ru-fu requested a review from tomponline as a code owner April 19, 2024 12:13
@github-actions github-actions bot added the Documentation Documentation needs updating label Apr 19, 2024
Copy link

Heads up @ru-fu - the "Documentation" label was applied to this issue.

Add and describe the figures

Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
@ru-fu ru-fu force-pushed the LXD-539-networking-diagrams branch from 26fcc81 to d6b4900 Compare April 19, 2024 13:22
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the .ai file? It seems to include internal references to /Users/trinabloemen/Library/CloudStorage/GoogleDrive-trinabloemen@gmail.com/My Drive/Upwork 2023/Canonical - Ege/2024 Pulse #7/DES 1068 Diagram for product documentation/networking_one-network.png

@tomponline
Copy link
Member

Also we've tended to use .jpg for other images, is it intentional to have these as .svg? Does that have the same level of browser support?

@ru-fu
Copy link
Contributor Author

ru-fu commented Apr 19, 2024

What is the .ai file? It seems to include internal references to /Users/trinabloemen/Library/CloudStorage/GoogleDrive-trinabloemen@gmail.com/My Drive/Upwork 2023/Canonical - Ege/2024 Pulse #7/DES 1068 Diagram for product documentation/networking_one-network.png

It's the source of the diagrams (probably Adobe Illustrator?). I think it might be good to keep it in case we want to request updates to the diagrams in the future.

@tomponline
Copy link
Member

It's the source of the diagrams (probably Adobe Illustrator?). I think it might be good to keep it in case we want to request updates to the diagrams in the future.

Agreed, lets put it into the internal LXD drive.

@ru-fu
Copy link
Contributor Author

ru-fu commented Apr 19, 2024

Also we've tended to use .jpg for other images, is it intentional to have these as .svg? Does that have the same level of browser support?

We have PNG for screenshots and SVG for diagrams.
SVG are much better quality (and don't loose quality when zooming in). And yes, no issues with browser support: https://caniuse.com/svg

@ru-fu ru-fu force-pushed the LXD-539-networking-diagrams branch from d6b4900 to dd306c5 Compare April 19, 2024 13:46
@tomponline tomponline merged commit ac79a5b into canonical:main Apr 19, 2024
29 checks passed
@ru-fu ru-fu deleted the LXD-539-networking-diagrams branch April 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants