Storage: Round ZFS volume sizes to nearest 16KiB #13470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MggMuggins
force-pushed
the
fix-zfs-size-rounding
branch
from
b8512a4
to
b604562
Compare
Thanks for finding this bug! It looks like the change was integrated in OpenZFS 2.2.0. It's weird that it took so long to be noticed here. |
Need to be able to check the block size associatd with a volume for zfs (see next commit) Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
MggMuggins
force-pushed
the
fix-zfs-size-rounding
branch
from
b604562
to
bae75fe
Compare
tomponline
reviewed
May 22, 2024
tomponline
reviewed
May 22, 2024
tomponline
reviewed
May 22, 2024
Fixes canonical#13420 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
MggMuggins
force-pushed
the
fix-zfs-size-rounding
branch
from
bae75fe
to
034f8ec
Compare
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
MggMuggins
force-pushed
the
fix-zfs-size-rounding
branch
from
478f770
to
9833d46
Compare
|
Thanks! Please can you add a test to https://github.com/canonical/lxd-ci/blob/main/tests/storage-vm so that we can ensure this fix is backported to the other tracks. |
tomponline
approved these changes
May 23, 2024
This was referenced May 23, 2024
tomponline
added a commit
to tomponline/lxd-pkg-snap
that referenced
this pull request
Jun 7, 2024
For canonical/lxd#13470 Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rounds ZFS volume sizes using
zfs.blocksizeor the openzfs default 16KiB instead of LXD's default 8KiB. Reported in #13420.It looks like the default was changed in OpenZFS in Q3 2021: openzfs/zfs#12406
I'm not super pleased with the refactor of
roundVolumeBlockSizeBytesto take avol Volume, but we need a reference to the volume in order to query its config keys. This seemed like the least invasive way to accomplish it.The new test fails before patches and passes after.